Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl update method has no proxy settings and forcing update name by user is not validated #58

Open
mlukaszewski opened this issue Mar 12, 2014 · 2 comments
Open

curl update method has no proxy settings and forcing update name by user is not validated #58

mlukaszewski opened this issue Mar 12, 2014 · 2 comments

Comments

@mlukaszewski
Copy link

curl option can and have to use proxy settings too.

second case is if user force update method there is no validation of choosen option.

I'll write patch
@mimmi20
Copy link

mimmi20 commented Mar 12, 2014

Please look at issue #38 and PR #53 for your second case. If you are readycould you submit your changes also to https://github.com/browscap/browscap-php ?

@mlukaszewski
Copy link
Author

I'm ready. I'll submit today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mimmi20 @mlukaszewski