Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Support custom instruments #1

Open
ghost opened this issue Dec 10, 2018 · 2 comments
Open

Support custom instruments #1

ghost opened this issue Dec 10, 2018 · 2 comments
Labels
enhancement New feature or request .nbs Bugs related to .nbs file parsing or saving

Comments

@ghost
Copy link

ghost commented Dec 10, 2018

nbs files can contain custom instruments. nbsplayer should support this.
@ghost ghost added the enhancement New feature or request label Dec 10, 2018
@ghost ghost added the .nbs Bugs related to .nbs file parsing or saving label Dec 23, 2018
@ghost
Copy link
Author

ghost commented Dec 23, 2018 •
edited by ghost
Loading

The builtin instruments should be implemented similarly to custom instruments. This would also allow changing the sound file for the builtin ones.

  • Add a isBuiltin field to Instrument to differentiate instruments (builtin ones should not be written)
  • Add instruments to Song that will contain all the song's instruments, including the builtins
  • Add some options in settings to change instruments

ghost pushed a commit that referenced this issue Dec 25, 2018
@GarboMuffin
very basic editing
885936c 
partially addresses #1, #3
@TheGreatFoxxy
Copy link

I can do this for 3 instruments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request .nbs Bugs related to .nbs file parsing or saving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheGreatFoxxy