Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box to box collision solver #953

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

fallenatlas
Copy link
Contributor

@fallenatlas fallenatlas commented Feb 6, 2024

Description

It kinda looks like it should on the surface.

Problem

It doesn't look like it should underneath.

  1. It's not xpbd like - solving should be done with a constraint (I believe);
  2. It doesnt consider the weight of the objects - everything is either unmovable or has mass 1kg;
  3. We'll find more problems.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Add entry to the changelog's unreleased section.

@fallenatlas fallenatlas self-assigned this Feb 6, 2024
@fallenatlas fallenatlas linked an issue Feb 6, 2024 that may be closed by this pull request
@fallenatlas fallenatlas added this to the 0.1 Jammable Engine milestone Feb 6, 2024
@fallenatlas fallenatlas marked this pull request as ready for review February 7, 2024 14:14
@fallenatlas fallenatlas force-pushed the 532-add-box-to-box-collision-solver branch from 6b00d13 to 6340667 Compare February 7, 2024 14:15
@github-actions github-actions bot added the S-Blocked Blocked on another issue or PR label Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-953/
on branch gh-pages at 2024-02-16 20:52 UTC

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (4f33ed6) 36.20% compared to head (f82f088) 36.13%.

Files Patch % Lines
engine/src/physics/plugin.cpp 0.00% 30 Missing ⚠️
engine/src/physics/solver.cpp 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   36.20%   36.13%   -0.07%     
==========================================
  Files         296      297       +1     
  Lines       24353    24397      +44     
==========================================
- Hits         8818     8817       -1     
- Misses      15535    15580      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallenatlas fallenatlas force-pushed the 532-add-box-to-box-collision-solver branch 2 times, most recently from 86dfefd to ac23728 Compare February 12, 2024 18:25
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Adding the physics bundle to 0.1 would make life way easier in the demo. It also means that we could make implementation components private (like the xpbd stuff) later on

engine/include/cubos/engine/physics/solver/solver.hpp Outdated Show resolved Hide resolved
engine/samples/collisions/main.cpp Outdated Show resolved Hide resolved
engine/samples/collisions/main.cpp Outdated Show resolved Hide resolved
@fallenatlas fallenatlas force-pushed the 532-add-box-to-box-collision-solver branch from ac23728 to a30d178 Compare February 16, 2024 20:51
@fallenatlas fallenatlas removed the S-Blocked Blocked on another issue or PR label Feb 16, 2024
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just don't forget to update the changelog before merging!

@github-actions github-actions bot added the S-Blocked Blocked on another issue or PR label Feb 16, 2024
@fallenatlas fallenatlas merged commit b342eb5 into main Feb 16, 2024
11 checks passed
@fallenatlas fallenatlas deleted the 532-add-box-to-box-collision-solver branch February 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Engine B-Physics S-Blocked Blocked on another issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Box to Box collision solver
2 participants