-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add box to box collision solver #953
Conversation
6b00d13
to
6340667
Compare
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 36.20% 36.13% -0.07%
==========================================
Files 296 297 +1
Lines 24353 24397 +44
==========================================
- Hits 8818 8817 -1
- Misses 15535 15580 +45 ☔ View full report in Codecov by Sentry. |
86dfefd
to
ac23728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Adding the physics bundle to 0.1 would make life way easier in the demo. It also means that we could make implementation components private (like the xpbd stuff) later on
ac23728
to
a30d178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just don't forget to update the changelog before merging!
Description
It kinda looks like it should on the surface.
Problem
It doesn't look like it should underneath.
Checklist