Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move Cubos to core #910

Merged
merged 2 commits into from
Jan 29, 2024
Merged

refactor: move Cubos to core #910

merged 2 commits into from
Jan 29, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Jan 29, 2024 •
edited
Loading

Description

Moves the Cubos class from the engine to the core/ecs directory.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@RiscadoA RiscadoA added A-Core A-Engine C-Code-Quality A section of code that is hard to understand or change B-Cubos labels Jan 29, 2024
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Jan 29, 2024
@RiscadoA RiscadoA self-assigned this Jan 29, 2024
@RiscadoA RiscadoA linked an issue Jan 29, 2024 that may be closed by this pull request
Move Cubos to the core #900
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-29 20:56 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c1254c) 49.16% compared to head (9dfab9c) 48.71%.

❗ Current head 9dfab9c differs from pull request most recent head cc14138. Consider uploading reports for the commit cc14138 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   49.16%   48.71%   -0.46%     
==========================================
  Files         132      134       +2     
  Lines        7881     7955      +74     
==========================================
  Hits         3875     3875              
- Misses       4006     4080      +74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 900-move-cubos-to-the-core branch 5 times, most recently from 777b8a5 to 9dfab9c Compare January 29, 2024 20:37
@RiscadoA RiscadoA merged commit 1bdd974 into main Jan 29, 2024
8 checks passed
@RiscadoA RiscadoA deleted the 900-move-cubos-to-the-core branch January 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoMendonc-a DiogoMendonc-a Awaiting requested review from DiogoMendonc-a

@roby2014 roby2014 Awaiting requested review from roby2014

@fallenatlas fallenatlas Awaiting requested review from fallenatlas fallenatlas is a code owner

Assignees

@RiscadoA RiscadoA

Labels
A-Core A-Engine C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Move Cubos to the core
1 participant
@RiscadoA