Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reserved keyword in Gizmos shader #902

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Replace reserved keyword in Gizmos shader #902

merged 1 commit into from
Jan 29, 2024

Conversation

tomas7770
Copy link
Contributor

Description

Replaces GLSL reserved word "output" in gizmos id shader with "idOutput" (same as the screen picking shader).

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@tomas7770 tomas7770 linked an issue Jan 27, 2024 that may be closed by this pull request
Reserved GLSL word in Gizmos shader #879
Closed
@github-actions github-actions bot added A-Engine B-Gizmos C-Crash D-Trivial Can be done in 30 minutes S-Triage Issues whose priority still has to be figured out labels Jan 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-29 20:28 UTC

RiscadoA
RiscadoA approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for working on this!

@tomas7770 tomas7770 merged commit 1c1254c into main Jan 29, 2024
10 checks passed
@tomas7770 tomas7770 deleted the 879-reserved-glsl-word-in-gizmos-shader branch January 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@DiogoMendonc-a DiogoMendonc-a Awaiting requested review from DiogoMendonc-a

Assignees
No one assigned
Labels
A-Engine B-Gizmos C-Crash D-Trivial Can be done in 30 minutes S-Triage Issues whose priority still has to be figured out
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reserved GLSL word in Gizmos shader
2 participants
@tomas7770 @RiscadoA