Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two small fixes to crash causing bugs #1347

Closed
wants to merge 3 commits into from

Conversation

SrGesus
Copy link
Contributor

@SrGesus SrGesus commented Oct 14, 2024

Description

  • Play Pause plugin was missing a ImGui::End() call when ImGui::Begin() returns false.

  • ECS would crash when an onRemove observer made a change to the entity

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.20%. Comparing base (4f2187d) to head (10f8d71).

Files with missing lines Patch % Lines
core/src/ecs/world.cpp 66.66% 1 Missing ⚠️
engine/src/tools/play_pause/plugin.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   40.19%   40.20%           
=======================================
  Files         437      437           
  Lines       31003    31006    +3     
=======================================
+ Hits        12463    12465    +2     
- Misses      18540    18541    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SrGesus
Copy link
Contributor Author

SrGesus commented Oct 15, 2024

noticed identical problem in World::destroy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant