Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add With and Without filters to queries #682

Closed
luishfonseca opened this issue Oct 6, 2023 · 3 comments
Closed

Add With and Without filters to queries #682

luishfonseca opened this issue Oct 6, 2023 · 3 comments
Labels
A-Core B-ECS D-Trivial Can be done in 30 minutes

Comments

@luishfonseca
Copy link
Contributor

luishfonseca commented Oct 6, 2023

Problem

Right now the only way to filter out entities with certain components is by reading those components.
This means that even if our system is just checking if an entity has a component and not accessing its data, it can't run at the same time as a system which is writing to that component.

Solution

Add With<Component> and Without<Component> filters to the query, which don't provide data access.

@luishfonseca luishfonseca added A-Core B-ECS S-Triage Issues whose priority still has to be figured out labels Oct 6, 2023
@luishfonseca luishfonseca added this to the 0.1 Jammable Engine milestone Oct 6, 2023
@RiscadoA
Copy link
Member

RiscadoA commented Oct 7, 2023

Wait these filters wouldn't solve the problem. They would be equivalent to Read/Write but without the data access. We need something else which allows checking if an entity has a component independently of the query ig?

@luishfonseca
Copy link
Contributor Author

True, it's an harder problem to solve than i tough. Feel free to rename and edit my request

@RiscadoA RiscadoA changed the title Add With and Without filters to query Add With and Without filters to queries Oct 7, 2023
@RiscadoA
Copy link
Member

RiscadoA commented Oct 7, 2023

Created another issue for the dynamic component checking part: #683.

@RiscadoA RiscadoA removed the S-Triage Issues whose priority still has to be figured out label Oct 15, 2023
@RiscadoA RiscadoA added the D-Trivial Can be done in 30 minutes label Oct 15, 2023
@RiscadoA RiscadoA closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core B-ECS D-Trivial Can be done in 30 minutes
Projects
None yet
Development

No branches or pull requests

2 participants