Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ECS onRemove observer bug #1348

Closed
SrGesus opened this issue Oct 17, 2024 · 0 comments · Fixed by #1350
Closed

Fix ECS onRemove observer bug #1348

SrGesus opened this issue Oct 17, 2024 · 0 comments · Fixed by #1350
Labels
A-Core B-ECS C-Crash D-Trivial Can be done in 30 minutes
Milestone
0.5

Comments

@SrGesus
Copy link
Contributor

SrGesus commented Oct 17, 2024 •
edited
Loading

Description

Removing component from entity or destroying entity with a component that is being observed causes crash if the target entity is changed inside the observer.

Additional context

Bug was already being resolved on PR #1347, making this issue for the convenience of being in a branch (documentation preview pipelines aren't working with forks).
@SrGesus SrGesus added A-Core B-ECS C-Crash D-Trivial Can be done in 30 minutes labels Oct 17, 2024
@SrGesus SrGesus linked a pull request Oct 19, 2024 that will close this issue
fix(core): Fix ECS onRemove observer bug #1350
Merged
5 tasks
@RiscadoA RiscadoA added this to the 0.5 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Core B-ECS C-Crash D-Trivial Can be done in 30 minutes
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

fix(core): Fix ECS onRemove observer bug GameDevTecnico/cubos
2 participants
@RiscadoA @SrGesus