From 9d3ef8a7edf5ac46419876e800cceb9afc17d689 Mon Sep 17 00:00:00 2001 From: Ricardo Antunes Date: Sun, 1 Oct 2023 13:27:15 +0100 Subject: [PATCH] style: follow clang-tidy suggestions Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- core/src/cubos/core/gl/ogl_render_device.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/core/src/cubos/core/gl/ogl_render_device.cpp b/core/src/cubos/core/gl/ogl_render_device.cpp index 0b19c59d30..0f7f000e79 100644 --- a/core/src/cubos/core/gl/ogl_render_device.cpp +++ b/core/src/cubos/core/gl/ogl_render_device.cpp @@ -1655,7 +1655,7 @@ Sampler OGLRenderDevice::createSampler(const SamplerDesc& desc) glGenSamplers(1, &id); glSamplerParameteri(id, GL_TEXTURE_MIN_FILTER, static_cast(minFilter)); glSamplerParameteri(id, GL_TEXTURE_MAG_FILTER, static_cast(magFilter)); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glSamplerParameteri(id, GL_TEXTURE_MAX_ANISOTROPY_EXT, static_cast(desc.maxAnisotropy)); } @@ -1707,7 +1707,7 @@ Texture1D OGLRenderDevice::createTexture1D(const Texture1DDesc& desc) glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glTexParameterf(GL_TEXTURE_1D, GL_TEXTURE_MAX_ANISOTROPY_EXT, 1.0F); } @@ -1751,7 +1751,7 @@ Texture2D OGLRenderDevice::createTexture2D(const Texture2DDesc& desc) glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MAX_ANISOTROPY_EXT, 1.0F); } @@ -1803,7 +1803,7 @@ Texture2DArray OGLRenderDevice::createTexture2DArray(const Texture2DArrayDesc& d glTexParameteri(GL_TEXTURE_2D_ARRAY, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D_ARRAY, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D_ARRAY, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glTexParameterf(GL_TEXTURE_2D_ARRAY, GL_TEXTURE_MAX_ANISOTROPY_EXT, 1.0F); } @@ -1854,7 +1854,7 @@ Texture3D OGLRenderDevice::createTexture3D(const Texture3DDesc& desc) glTexParameteri(GL_TEXTURE_3D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_3D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_3D, GL_TEXTURE_WRAP_R, GL_CLAMP_TO_EDGE); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glTexParameterf(GL_TEXTURE_3D, GL_TEXTURE_MAX_ANISOTROPY_EXT, 1.0F); } @@ -1912,7 +1912,7 @@ CubeMap OGLRenderDevice::createCubeMap(const CubeMapDesc& desc) glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glTexParameterf(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAX_ANISOTROPY_EXT, 1.0F); } @@ -1967,7 +1967,7 @@ CubeMapArray OGLRenderDevice::createCubeMapArray(const CubeMapArrayDesc& desc) glTexParameteri(GL_TEXTURE_CUBE_MAP_ARRAY, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_CUBE_MAP_ARRAY, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_CUBE_MAP_ARRAY, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); - if (GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic != 0) { glTexParameterf(GL_TEXTURE_CUBE_MAP_ARRAY, GL_TEXTURE_MAX_ANISOTROPY_EXT, 1.0F); } @@ -2519,7 +2519,7 @@ int OGLRenderDevice::getProperty(Property prop) switch (prop) { case Property::MaxAnisotropy: - if (!GLAD_GL_ARB_texture_filter_anisotropic) + if (GLAD_GL_ARB_texture_filter_anisotropic == 0) { return 1; }