Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts logos and designs to html table (from markdown-in-html) #180

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

brentryanjohnson
Copy link
Contributor

  • Reverts logos and designs table from using markdown in HTML (to resolve image paths in cloud.gov pages) to using HTML
  • Takes advantage of refactor link / image plugins #168 to use img tags in HTML table

The markdown-in-HTML approach worked fine, but it added a p element around every image in the table cell. This had the effect of adding additional margin to each table cell. Using HTML instead of markdown in HTML clears this unwanted white space, and removes unnecessary p elements from the table.

Before

Screenshot of logos and designs page with rows for logo and card designs with white space above and below the content of table cells

This PR

Screenshot of logos and designs page with rows for logo and card designs with reduced white space above and below the content of table cells

@JessicaMarine1
Copy link
Contributor

Does this change make it harder for the POs to update content?

@brentryanjohnson
Copy link
Contributor Author

In my opinion, no, it doesn't make it harder. The previous version still used HTML (because we can't style a markdown table, and we need the borderless CSS class to match the design), but it mixed markdown syntax (only for images) into the HTML. Theoretically, that could have been more difficult for POs to update, since it mixed HTML and markdown together in a single element.

Copy link
Contributor

@mark-meyer mark-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@brentryanjohnson brentryanjohnson merged commit 09d3d88 into main Jul 11, 2023
1 check passed
@brentryanjohnson brentryanjohnson deleted the rj-section-about-logos-2 branch July 11, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants