Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faq pages #159

Merged
merged 19 commits into from
Jul 7, 2023
Merged

faq pages #159

merged 19 commits into from
Jul 7, 2023

Conversation

weiwang-gsa
Copy link
Contributor

@weiwang-gsa weiwang-gsa commented Jul 5, 2023

  • added faq collections, which will make /faq/state-tax ...etc routes working
  • added index.astro to combine all the content from faq collection, route as /faq/
  • added dynamic accordion which support different heading level
  • added js to support full text search and increase heading level for home FAQ page as additional h1 is added
  • added single sidenav using headings as parent menu.
  • added css to make the sidebar stick to the screen top left section.

Copy link
Contributor

@mark-meyer mark-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work...
There's a handful of comments here. Let me know I should clarify anything or misunderstood something.

src/components/GSAHeader.astro Outdated Show resolved Hide resolved
src/content/faq/merchants.mdx Outdated Show resolved Hide resolved
src/pages/faq/[...slug].astro Outdated Show resolved Hide resolved
src/pages/faq/[...slug].astro Outdated Show resolved Hide resolved
src/assets/js/faqHelper.js Outdated Show resolved Hide resolved
src/components/Accordion.astro Show resolved Hide resolved
src/content/faq/state-tax.mdx Outdated Show resolved Hide resolved
src/pages/faq/index.astro Outdated Show resolved Hide resolved
Copy link
Contributor

@mark-meyer mark-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@mark-meyer mark-meyer merged commit 3c0f170 into main Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants