Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds how-it-works section content #156

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

brentryanjohnson
Copy link
Contributor

@brentryanjohnson brentryanjohnson commented Jun 29, 2023

Closes #31 and #36

  • Adds how-it-works section with two pages
  • Some links won't work because about section not yet merged
  • Couldn't preview because paths aren't yet resolved

Dev review

  • The How GSA SmartPay® Works page makes use of the USWDS process list component. This might be candidate for a component + mdx in Astro (currently it's inline HTML in the markdown file), but to my knowledge, this is the only instance in which we use this component.

  • The site currently lacks a page and [...slug] file for how-it-works (as exist for about)

Copy link
Contributor

@weiwang-gsa weiwang-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@weiwang-gsa weiwang-gsa merged commit ec621ff into main Jun 29, 2023
@brentryanjohnson brentryanjohnson deleted the rj-section-how-it-works branch September 11, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How the Program Works
2 participants