Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LibSass 3.5.4 inspect() bug #100

Merged
merged 1 commit into from
Oct 18, 2019
Merged

fix: LibSass 3.5.4 inspect() bug #100

merged 1 commit into from
Oct 18, 2019

Conversation

carlosvalle
Copy link
Contributor

@carlosvalle carlosvalle commented Oct 17, 2019

inspect() function should return an unquoted string when passed a
quote string - sass/libsass#2826

This bug has been fixed in LibSass 3.6.0 - unfortunatelly node-sass its
having issues updating to 3.6.0 (sass/node-sass#2685)
While we wait for node-sass.

⚠️ We need to make sure that values that we
pass to the utilities mixins are exactly as described in
_system-tokens.scss

inspect() function should return an unquoted string when passed a
quote string - sass/libsass#2826

This bug has been fixed in LibSass 3.6.0 - unfortunatelly node-sass its
having issues updating to 3.6.0
(sass/node-sass#2685)
While we wait for node-sass. We need to make sure that values that we
pass to the utilities mixins are exactly as described in _system-tokens.scss
Copy link
Contributor

@thomastighe thomastighe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@carlosvalle carlosvalle merged commit 8082c1b into master Oct 18, 2019
@carlosvalle carlosvalle deleted the bug-fix branch October 18, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants