Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix date error after busybox #4605

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix date error after busybox #4605

merged 1 commit into from
Feb 1, 2024

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Feb 1, 2024

the bin/check-and-renew has been broken for long. it is time to fix it.

image

the reason it is broken is described in cloud-gov/cg-cli-tools#23, to fix it, a sed command it added to convert string "2024-02-01T17:02:55.83+0000" to "2024-02-01 17:02:55" for busybox date to read.

@FuhuXia FuhuXia requested a review from a team February 1, 2024 22:22
@btylerburton btylerburton merged commit 40bcb31 into main Feb 1, 2024
@btylerburton btylerburton deleted the busybox-date branch February 1, 2024 22:24
@FuhuXia
Copy link
Member Author

FuhuXia commented Feb 2, 2024

After cloud-gov/cg-cli-tools#26 merged, we can remove this ugly fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants