Rewrite cypress test in dcat_usmetadata app

[rshewitt]

User Story

In order to make the integrations tests of the dcat_usmetadata app more consistent, predictable, and reliable, datagov wants to rewrite existing flaky tests.

Acceptance Criteria

• GIVEN the current integration tests
  WHEN new tests are written and executed
  THEN the tests will pass or fail without the need to retry
  AND the results will accurately reflect the nature of the app.

Background

• many of the integrations test are known for being unreliable, requiring multiple re-runs to pass.
• the result of a test should be reliable and reflective of how the app works.

examples

• user-flow
  • Displays confirmation page when clicked
• resource-upload
  • Resource radio buttons work, Works when editing a resource during dataset creation
• additional-metadata
  • Goes back to previous page, Saves dataset using "Save draft" button

Sketch

• identify complete list of tests needing to be re-written.
• determine new test to create