Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4th order derivative stencils hard-coded in GammaCalculator class #251

Open
the-florist opened this issue Apr 30, 2024 · 1 comment · May be fixed by #252
Open

4th order derivative stencils hard-coded in GammaCalculator class #251

the-florist opened this issue Apr 30, 2024 · 1 comment · May be fixed by #252

Comments

@the-florist
Copy link
Member

The GammaCalculator class (Source/CCZ4/GammaCalculator.hpp) uses a m_deriv object to calculate spatial derivatives of the spatial tensor, but declares this m_deriv object as a protected ForthOrderDerivatives object belonging to the class, and does not change the type of the object depending on the max_spatial_derivative_order flag in params, nor does it throw an error if the user requests 6th order derivatives.

I'm happy to write a bit of code to either create this dependence on the max_spatial_derivative_order flag, or throw an error if a larger derivative order is requested.

-- Ericka

@mirenradia
Copy link
Member

I guess it would be best to just template the class over a deriv_t type with default FourthOrderDerivatives. Feel free to open a PR to do this.

@mirenradia mirenradia linked a pull request May 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants