Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement symmetry in volume integrals #197

Open
KAClough opened this issue Oct 13, 2021 · 0 comments · May be fixed by #256
Open

Implement symmetry in volume integrals #197

KAClough opened this issue Oct 13, 2021 · 0 comments · May be fixed by #256
Assignees
@KAClough @mirenradia @the-florist
Labels
bug Something isn't working enhancement Modification of existing feature/general improvement

Comments

@KAClough
Copy link
Member

The flux calculations take into account the symmetry of the domain, but the volume integrals currently do not... this has led to a bit of confusion, so we should make them consistent. It should be relatively simple to multiply any volume integrals by a factor of the symmetry. This way fluxes and volume integrals will match up.
@KAClough KAClough added bug Something isn't working enhancement Modification of existing feature/general improvement labels Oct 13, 2021
@the-florist the-florist linked a pull request Sep 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KAClough KAClough

@mirenradia mirenradia

@the-florist the-florist

Labels
bug Something isn't working enhancement Modification of existing feature/general improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/integral symmetry factor GRTLCollaboration/GRChombo
3 participants
@KAClough @mirenradia @the-florist