Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PunctureTracker interpolation is inefficient #184

Open
mirenradia opened this issue Aug 1, 2021 · 0 comments
Open

PunctureTracker interpolation is inefficient #184

mirenradia opened this issue Aug 1, 2021 · 0 comments
Assignees
Labels
enhancement Modification of existing feature/general improvement

Comments

@mirenradia
Copy link
Member

Currently, all MPI ranks request interpolation of the shift in the puncture tracker but this is unnecessary as only rank 0 writes the output. Note that other ranks may need information on the location of the punctures (e.g. for tagging) so the best approach would be for only rank 0 to request the interpolation of the shift and then broadcast the calculated position to all other ranks.

Note that is similar to what was done in #147 for SurfaceExtraction so an alternative approach would be to create an interface to the AMRInterpolator that only interpolates onto rank 0?

@mirenradia mirenradia added the enhancement Modification of existing feature/general improvement label Aug 1, 2021
@mirenradia mirenradia self-assigned this Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Modification of existing feature/general improvement
Projects
None yet
Development

No branches or pull requests

1 participant