Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualisation bug when plot files have ghosts #101

Open
mirenradia opened this issue Mar 28, 2020 · 4 comments
Open

Fix visualisation bug when plot files have ghosts #101

mirenradia opened this issue Mar 28, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mirenradia
Copy link
Member

There is a problem with ParaView (and possibly VisIt) when plot files have ghosts. Apparently @KAClough knows what to do...

@mirenradia mirenradia added the bug Something isn't working label Mar 28, 2020
@KAClough
Copy link
Member

Note to self having looked at this a bit more:

  • The issue is really one in visit/paraview where it considers the surface through the point(0,0,0) as lying in the boundary cells which are classed as ghost cells. Really this is exactly on the boundary between the domain and the ghosts. When one doesn't write ghosts Visit seems to figure out that this point should be included in the domain.
  • It happens both checkpoints (which always output ghosts) and plot files with ghosts.
  • Although this is really a visualisation bug it could be fixed by us:
  1. It might be possible to just fix it by redefining the valid domain when the data is output.
  2. We could only output the boundary cells in sommerfeld directions, and not all ghosts. The ones on symmetric and extrapolating boundaries (which are usually where you try to plot) can be recovered from the symmetry conditions, and the internal ghost cells are clearly not needed at all. This would then reduce enormously the memory footprint of the checkpoint files, so would be worth doing just for that.

@KAClough
Copy link
Member

I also note that no one should need to output plot ghosts any more since the boundary updates - which mean that one can set extrapolating bcs to fill sommerfeld cells in any restart from plot files in post processing. So we should consider removing this feature. This doesn't solve the checkpoint issue though.

@mirenradia
Copy link
Member Author

I'm wondering if we can get away with using the GRAMRLevel::m_grown_grids ProblemDomain for writing checkpoints (in the case of Sommerfeld BCs) and not including any other ghosts.

@KAClough
Copy link
Member

Yes, that would be great if it works. We would just need to check the chombo copes with reading it back into m_state_new for the checkpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants