Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in computing shadow accumulation #49

Open
adiblev opened this issue Jan 9, 2023 · 0 comments
Open

typo in computing shadow accumulation #49

adiblev opened this issue Jan 9, 2023 · 0 comments

Comments

@adiblev
Copy link

adiblev commented Jan 9, 2023

Hi guys,

Going over the code we assume that intention was to compute: #fibers = distance / (strand radius + spacing between strands) but due to a typo used multiplication instead of addition.

Was that indeed a typo or intentional?

float numFibers = fDepthDistanceWS / (fFiberSpacing * fFiberRadius); // fiberSpacing + fiberRadius is total distance from 1 fiber to another

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant