Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal energy #111

Open
aiayalaz opened this issue Feb 9, 2021 · 1 comment
Open

internal energy #111

aiayalaz opened this issue Feb 9, 2021 · 1 comment

Comments

@aiayalaz
Copy link

aiayalaz commented Feb 9, 2021

I have checked how rLakeAnalyzer performed the internal energy calculation and there seems to be an error in the units.
Internal energy = sum(volumedensitytemperature*Cpw)/Surface area
Cpw is 4186 J kg-1 degK-1, then temperature should be in kelvin as well (in the function internal.energy.R wtr is in degC)

@jordansread
Copy link
Member

Hmm...I haven't dug into the code, but thermal energy is calculated relative to a base temperature, which is arbitrary, as long as you use the same base temperature when comparing states. Often 0°C is used, 0K, or 20°C. Here we're using 0°C as the base. Do you see this difference impacting the calculations? If so, can you point out where/how to help us address it or further evaluate? Either way, including the base temperature in the docs for this function seems important/useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants