Invalid packages import for geos-mesh, impacting documentation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce leading to error when creating documentation
|
seems not to be enough |
|
I tried the sphinx-build with all .rst files and weirdly, certain of them raise an error when reaching this line :
Do you know @untereiner if I can contact someone to help me with the sphinx-build ? |
…tation. Argparse filename used instead.
|
The sphinx-build works on my side, generating the complete documentation. |
|
|
|
@untereiner It appeared to be a sphinx / sphinx-argparse update required for the modules to be now recognized. |
|
@untereiner I think it's ok now to merge |
untereiner
approved these changes
Aug 5, 2024
alexbenedicto
added a commit
that referenced
this pull request
Oct 14, 2024
* First correction now allowing for the copy of fields from the original mesh to the 2 split meshes. But the indexes of fields are not correct yet for fracture mesh. * Module import paths update * Fields are now copied correctly for fracture_mesh. * Test case added to check the __copy_fields feature. * Invalid packages import for geos-mesh, impacting documentation (#32) Updating sphinx and sphinx-argparse solved the issue. * Correction for yapf valid format. * Had to make a workaround to avoid a weird yapf formatting suggestion. * Mistake correction * First correction now allowing for the copy of fields from the original mesh to the 2 split meshes. But the indexes of fields are not correct yet for fracture mesh. * Module import paths update * Fields are now copied correctly for fracture_mesh. * Test case added to check the __copy_fields feature. * Correction for yapf valid format. * Had to make a workaround to avoid a weird yapf formatting suggestion. * Mistake correction * First part of review corrections * Second part correction of reviews * Last part of correction review * Updated method when linking old cells to new cells ids to copy correctly the fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #29
Geos-mesh feature files could not import packages from "src" correctly,
showing import errors in the documentation.