Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add functions to connect well perforation to surface elements #3359

Open
wants to merge 11 commits into
base: pt/well-frac
Choose a base branch
from

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Sep 19, 2024

  • move calculateElementCenters for subregions earlier into FaceManager::computeGeometry, so cell centers for surface elements are available when well perforation is processed
  • remove registerWrapper for elementCenter and elementVolume in EmbeddedSurfaceSubRegion, they already registered in the base class
  • modify getReservoirElementDimensions/getBoundingBox to support SurfaceElementSubRegion
  • add SurfaceElementSubRegion version of isPointInsideElement and helper functions isPointInPolygon2d/3d

(not super refined implementation but something to start working with)

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 27.45098% with 74 lines in your changes missing coverage. Please review.

Project coverage is 56.23%. Comparing base (c4eaa53) to head (d2fc2a6).
Report is 5 commits behind head on pt/well-frac.

Files with missing lines Patch % Lines
...omponents/mesh/utilities/ComputationalGeometry.hpp 1.88% 52 Missing ⚠️
src/coreComponents/mesh/WellElementSubRegion.cpp 21.73% 18 Missing ⚠️
src/coreComponents/mesh/PerforationData.cpp 77.77% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           pt/well-frac    #3359      +/-   ##
================================================
- Coverage         56.56%   56.23%   -0.33%     
================================================
  Files              1064     1065       +1     
  Lines             89872    90407     +535     
================================================
+ Hits              50832    50840       +8     
- Misses            39040    39567     +527     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin added the type: feature New feature or request label Oct 3, 2024
@paveltomin
Copy link
Contributor Author

need review please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant