-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add functions to connect well perforation to surface elements #3359
Open
paveltomin
wants to merge
11
commits into
pt/well-frac
Choose a base branch
from
pt/connect-well-to-2d-elem
base: pt/well-frac
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
requested review from
rrsettgast,
CusiniM,
jhuang2601,
castelletto1,
klevzoff,
francoishamon,
matteofrigo5,
wrtobin,
untereiner,
MelReyCG,
corbett5 and
cssherman
as code owners
September 19, 2024 16:16
paveltomin
requested review from
klevzoff,
CusiniM and
tjb-ltk
and removed request for
klevzoff,
wrtobin,
cssherman,
rrsettgast,
untereiner,
francoishamon,
corbett5,
castelletto1,
matteofrigo5,
CusiniM,
jhuang2601 and
MelReyCG
September 19, 2024 16:17
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pt/well-frac #3359 +/- ##
================================================
- Coverage 56.56% 56.23% -0.33%
================================================
Files 1064 1065 +1
Lines 89872 90407 +535
================================================
+ Hits 50832 50840 +8
- Misses 39040 39567 +527 ☔ View full report in Codecov by Sentry. |
need review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculateElementCenters
for subregions earlier intoFaceManager::computeGeometry
, so cell centers for surface elements are available when well perforation is processedregisterWrapper
forelementCenter
andelementVolume
inEmbeddedSurfaceSubRegion
, they already registered in the base classgetReservoirElementDimensions
/getBoundingBox
to supportSurfaceElementSubRegion
SurfaceElementSubRegion
version ofisPointInsideElement
and helper functionsisPointInPolygon2d/3d
(not super refined implementation but something to start working with)