Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding features to mesh_doctor #2270

Open
5 of 15 tasks
TotoGaz opened this issue Feb 3, 2023 · 1 comment
Open
5 of 15 tasks

Adding features to mesh_doctor #2270

TotoGaz opened this issue Feb 3, 2023 · 1 comment
Assignees
Labels
EPIC - Mesh/mesh_doctor Improving the `mesh_doctor` tool EPIC The agile epic concept type: feature New feature or request

Comments

@TotoGaz
Copy link
Contributor

TotoGaz commented Feb 3, 2023

Let's add new checks to mesh_doctor!

First batch of features done in #2274 :

  • Check that all the elements of the mesh are supported (including that polyhedra can be converted into supported elements).
  • Warn about "non-conformal" elements (in the sense that two close facing elements should not be shifted).
  • Allow reordering of support nodes for the elements. A right-hand left-hand rule could be fixed easily.
  • Checks that the polyhedra have their normals directed outwards. (not exposed through the CLI though)

More checkes:

  • Improve the fracture generation in mesh_doctor #2857
  • Improve the collocated_nodes feature so it handles the fractures as well (the nodes aside the fracture are legitimately colocated, but it creates noise that prevents from finding real issue).
  • Check that the fractured mesh is consistent (collocated nodes are really collocated)
  • Validate ranges of fields (e.g. density should be positive). Printing statistics for fields can be enough. Check for NaN. Check for connection numbers (can be useful since some arrays have a maximum size based on number of connections.)
  • Build some mesh statistics (cell types, cell sizes, number of cells sharing the same node, etc.)
  • Add a field manipulation feature that will (among other features) allow to grab one field from an output simulation into the input of another.
  • Try to find holes in the mesh.
  • Find isolated elements (unused points, disconnected cell...)
  • Pre-split tags can be erroneous issues Pre-split tags can be erroneous  #3222 and Pre-split tags can be erroneous geosPythonPackages#31 (comment)

Create a paraview plugin

@TotoGaz TotoGaz added type: feature New feature or request type: new A new issue has been created and requires attention labels Feb 3, 2023
@TotoGaz TotoGaz self-assigned this Feb 3, 2023
@TotoGaz TotoGaz removed the type: new A new issue has been created and requires attention label Feb 3, 2023
@TotoGaz TotoGaz removed their assignment May 7, 2023
@TotoGaz TotoGaz changed the title Adding checks to mesh_doctor Adding features to mesh_doctor Nov 1, 2023
@TotoGaz TotoGaz added EPIC The agile epic concept EPIC - Mesh/mesh_doctor Improving the `mesh_doctor` tool labels Nov 1, 2023
@herve-gross
Copy link
Contributor

please, @alexbenedicto : add issue #3222 to this epic

@alexbenedicto alexbenedicto self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - Mesh/mesh_doctor Improving the `mesh_doctor` tool EPIC The agile epic concept type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants