-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EDDSA #13
Comments
RFC specifying this: https://tools.ietf.org/html/rfc8037 |
Java supports EdDSA: https://openjdk.java.net/jeps/339 |
I could add support for this in the library, but this feature was included in Java 15. Ideally I'd only anchor to Java LTS releases. So I could:
|
Hacking a bit on this branch |
I would vote for either of the first options. |
Thanks for the feedback @Yaytay. |
Yeah one of the reasons I picked this library is it seems updated, just the right size code base wise, and well supported. Since you guys are newer smaller library (so hopefully less angry users on JDK upgrade) maybe we can get JDK 17 baseline and EdDSA support soon? |
See also |
One technique to the whole Java 17 issue that I have used several times is to use the ServiceLoader pattern. Write the ED part as a separate jar and if its included on the classpath it automatically is available. This is sort of like the reflection changes @robotdan talked about but it is far more canonical than a reflection hack (as well as Graal native friendly). I was looking at @robotdan changes to make EdDSA support work to see what is required to add a new algorithm and it appears the way things are currently designed with heavy use of enums that it would be a lot of work to add pluggable algorithms (and would probably require a major version change). Most of the problem is the enums but there are also classes that are essentially a merge of all the algorithms (JSONWebKey iirc). It is a shame though because I see value in having all the algorithms as modules (e.g. separate jars with a MET-INF/services registration) as folks could choose only the algorithms they want and say to their security team that there is no way they accidentally generate with some other algorithm... well maybe that is a dumb reason but it would make the deployed size every so slightly smaller. |
If I can find an evening to hack on the branch I started, I may be able to finish it. |
Taking a stab at a major version release of this library to make it more extendable, and taking my EdDSA branch and moving it to a new repo to prove the theory.
If it all holds together, I should get this out soon. |
Getting closer. I re-worked the branch and use the |
Add support EDDSA
https://tools.ietf.org/html/draft-josefsson-eddsa-ed25519-03#section-4
https://en.wikipedia.org/wiki/EdDSA
Related
The text was updated successfully, but these errors were encountered: