Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Song may restart at the end while missed notes pass by #3142

Open
2 tasks done
NotHyper-474 opened this issue Sep 13, 2024 · 25 comments
Open
2 tasks done
Assignees
Labels
status: needs clarification Requires more info from the contributor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Comments

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Sep 13, 2024

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Web)

If you are playing on a browser, which one are you using?

Firefox

Version

0.5.0

Context (Provide images, videos, etc.)

After a song ends, it might repeat once more. While this is happening "ghost" notes pass by.
Edit: In certain cases it seems like it'll keep repeating from where you last paused and basically getting you stuck unless you don't keep pausing and unpausing.

8mb.video-V09-1X6W5zzk.mp4

Steps to reproduce (or crash logs, errors, etc.)

  • Just play any song until the end. (I was testing this on Freeplay - Pico character, might need more testing.)
    This might not always happen and seems to occur more frequently on web builds when using Unlocked Framerate, but it is not necessarily caused by it.
@NotHyper-474 NotHyper-474 added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Sep 13, 2024
@NotHyper-474 NotHyper-474 changed the title Bug Report: Song might restart on end while "ghost" notes appear by Bug Report: Song may restart at the end while "ghost" notes scroll by Sep 13, 2024
@NotHyper-474 NotHyper-474 changed the title Bug Report: Song may restart at the end while "ghost" notes scroll by Bug Report: Song may restart at the end while "ghost" notes pass by Sep 13, 2024
@AbnormalPoof
Copy link
Contributor

I managed to reproduce this bug back in v0.4.1, but I simply thought it was an issue with one of my mods.

@EliteMasterEric EliteMasterEric pinned this issue Sep 13, 2024
@EliteMasterEric
Copy link
Member

Definitely looking for help diagnosing/reproducing this.

@saturn-volv
Copy link

I was encountering the same issue but can only reproduce it on web. I also use firefox.

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 13, 2024

I was encountering the same issue but can only reproduce it on web. I also use firefox.

Yeah I was trying it on the standalone build but couldn't reproduce it. Could be a browser / web version specific issue.

@NotHyper-474
Copy link
Contributor Author

I managed to reproduce this bug back in v0.4.1, but I simply thought it was an issue with one of my mods.

I also had managed to reproduce it in that version while I was testing #2706, but I was on WSL and couldn't replicate it again afterward.

@Hundrec
Copy link
Contributor

Hundrec commented Sep 13, 2024

Encountered this one at the end of Cocoa Erect on itch.io Web.

@NotHyper-474
Copy link
Contributor Author

Encountered this one at the end of Cocoa Erect on itch.io Web.

Were you perchance in Firefox as well?

@Hundrec
Copy link
Contributor

Hundrec commented Sep 13, 2024

I was using Brave when this happened

@KATBOI667
Copy link

Had this exact same thing happen to me on both DadBattle Pico & Blammed Pico

Opera GX, btw

@Denoohay
Copy link

Denoohay commented Sep 13, 2024

Had this issue happen to me in the windows build during my first time playing Pico (Pico Mix).

@Hundrec
Copy link
Contributor

Hundrec commented Sep 13, 2024

Just replicated this bug with Bopeebo (Pico Mix) on itch.io for Brave. The clip begins on the second loop of the song and goes into the third loop (which starts in the middle of the song).

Pico.ghost.loop.bug.mp4

@PlazmaZX
Copy link

I also had this happen to me whilst playing South (Pico Mix) on Newgrounds, also on Firefox. I think the ghost notes are notes you missed the first time round and they're just wrapping round the second time.

@Hundrec
Copy link
Contributor

Hundrec commented Sep 13, 2024

I also had this happen to me whilst playing South (Pico Mix) on Newgrounds, also on Firefox. I think the ghost notes are notes you missed the first time round and they're just wrapping round the second time.

I've observed this "wrapping around" effect as well!

@Pizzawishes
Copy link

Pizzawishes commented Sep 13, 2024

I literally can't complete Philly Nice (Pico Mix) and Blammed (Pico Mix) because of this issue
(I'm on the Newgrounds release)

@Raltyro
Copy link

Raltyro commented Sep 13, 2024

This can be happen in windows build too, just rarely unless framerate are unlocked it somehow increases the chances of it happening

@JustKolosaki
Copy link

JustKolosaki commented Sep 13, 2024

Got this bug as well while playing 2Hot on the itch.io version, as well as while playing on the web version (using Microsoft Edge).

I think this might happen is because Conductor sets the song position to 0.0 if FlxG.sound.music is null, which also restarts the song in PlayState's stepHit() function. Not sure why onComplete doesn't want to work for FlxG.sound.music, but if I find sumthin I'll edit da comment more.

@eXteRadis
Copy link

I experienced the same thing on Chrome

@EliteMasterEric EliteMasterEric self-assigned this Sep 13, 2024
@EliteMasterEric EliteMasterEric added status: cannot reproduce Involves a bug which cannot be reliably reproduced by reviewers. Assistance may be needed. and removed status: pending triage The bug or PR has not been reviewed yet. labels Sep 13, 2024
@NotHyper-474
Copy link
Contributor Author

Apparently it's easier to reproduce this issue if Unlocked Framerate is enabled, and doesn't seem to occur when it's disabled.

@bubl3
Copy link

bubl3 commented Sep 13, 2024

i have found multiple ways to reproduce this looping bug.
1st having unlocked fps usually makes songs loop all the time they rarely dont loop with unlocked fps and i dont know why.
2nd if u restart a song the chances of a song looping increases even with unlocked fps off
3rd it seems happen randomly also? but the 2 things i mentioned above are reproduceable at least for me
(im using Opera GX to play the game and im playing through newgrounds)

@HeroDaGr8
Copy link

This just happened to me moments ago. I was playing South on Hard in Story Mode, and when the song finished it didn't end but the song replayed and ghost notes passed by. I believe those notes might be the notes I missed before the song looped? But my game broke and the sprites became black after finishing the looped song. I'm on Opera Gx playing on Newgrounds btw

@NotHyper-474 NotHyper-474 changed the title Bug Report: Song may restart at the end while "ghost" notes pass by Bug Report: Song may restart at the end while missed notes pass by Sep 14, 2024
@EliteMasterEric EliteMasterEric added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression and removed type: minor bug Involves a minor bug or issue. labels Sep 15, 2024
@XLMdorentos
Copy link

I found how to reproduce this
You need to complete a song without misses (or maybe even without bads)
As soon as you miss for the first time all songs end as should

@EliteMasterEric EliteMasterEric added status: needs clarification Requires more info from the contributor. and removed status: cannot reproduce Involves a bug which cannot be reliably reproduced by reviewers. Assistance may be needed. labels Sep 16, 2024
@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 16, 2024

I've noticed that the position where the song loops isn't always from the beginning, but for some reason where you last paused.
If you pause and unpause enough times you can "break free" from the glitch.

Edit: Also apparently if you switch tabs the song will repeat from the last point and constantly reset that point until the song ends making the characters aggressively be forced to sync to the beat? This bug couldn't be more confusing.
Also could confirm that this bug isn't necessarily caused by Unlocked Framerates option but it does make it more common.

8mb.video-fBv-MDM0v0HE.mp4

@Hundrec
Copy link
Contributor

Hundrec commented Sep 16, 2024

What a bug! Pretty fun to mess around with, but definitely game-breaking every time I play.

@Raltyro
Copy link

Raltyro commented Sep 16, 2024

I feel like it has something todo with lime backend audio

@Blue2359
Copy link

Funny enough, this bug kept occurring for me when I was learning how to mod the game even before version 0.5.0; (on version 0.4...+).

It seems like the onComplete callback on the instrumental doesn't get properly called sometimes, I'm assuming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs clarification Requires more info from the contributor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Development

No branches or pull requests