Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to cc 1.0.83 and bump to 0.51.1 #5649

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Revert to cc 1.0.83 and bump to 0.51.1 #5649

merged 1 commit into from
Feb 23, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Feb 23, 2024

cc version 1.0.86 has a bug that blocks our cross compilation pipeline rust-lang/cc-rs#964

cc version 1.0.86 has a bug that blocks our cross compilation pipeline
rust-lang/cc-rs#964
@IGI-111 IGI-111 requested review from a team February 23, 2024 01:02
Copy link

Benchmark for a9c2510

Click to view benchmark
Test Base PR %
code_action 5.2±0.09ms 5.4±0.19ms +3.85%
code_lens 285.8±8.01ns 296.6±11.29ns +3.78%
compile 3.1±0.03s 3.1±0.04s 0.00%
completion 4.8±0.14ms 5.0±0.23ms +4.17%
did_change_with_caching 3.0±0.03s 3.0±0.02s 0.00%
document_symbol 962.8±12.69µs 962.4±12.36µs -0.04%
format 91.8±1.68ms 72.6±0.87ms -20.92%
goto_definition 361.5±8.39µs 366.7±10.64µs +1.44%
highlight 8.8±0.18ms 9.1±0.14ms +3.41%
hover 547.2±11.68µs 562.6±8.44µs +2.81%
idents_at_position 121.8±1.21µs 123.4±3.29µs +1.31%
inlay_hints 668.1±22.74µs 668.6±27.27µs +0.07%
on_enter 493.7±17.64ns 477.6±16.23ns -3.26%
parent_decl_at_position 3.6±0.03ms 3.8±0.17ms +5.56%
prepare_rename 358.8±6.62µs 365.4±7.31µs +1.84%
rename 9.1±0.13ms 9.5±0.17ms +4.40%
semantic_tokens 1069.9±17.84µs 1071.5±21.94µs +0.15%
token_at_position 362.7±3.12µs 364.3±3.55µs +0.44%
tokens_at_position 3.6±0.09ms 3.7±0.06ms +2.78%
tokens_for_file 413.5±4.90µs 498.8±3.69µs +20.63%
traverse 38.9±0.93ms 38.9±0.88ms 0.00%

@IGI-111 IGI-111 requested a review from a team February 23, 2024 03:07
@IGI-111 IGI-111 enabled auto-merge (squash) February 23, 2024 04:35
@IGI-111 IGI-111 merged commit d1e8f01 into master Feb 23, 2024
39 checks passed
@IGI-111 IGI-111 deleted the IGI-111/v0.51.1 branch February 23, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants