Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : Inconsistent footer bug fixed #246

Closed
wants to merge 1 commit into from
Closed

[fix] : Inconsistent footer bug fixed #246

wants to merge 1 commit into from

Conversation

AKACHI-4
Copy link
Contributor

Fixes Issue

Closes #236

Changes proposed

In the SiteFooter component, the items={socialConfig} part is missing in app > (batches) > layout.jsx and app > (docs) > layout.jsx. I added the part that passes as children to the SiteFooter component for rendering in sync.

<SiteFooter items={socialConfig} />

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Sorry, I was working on an Ubuntu machine and was unable to take a screenshot. You can view the Vercel preview, though. everything is working fine.

Kindly review my PR and suggest further changes if any..

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 4:21am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request and welcome to our community! We will be getting back to you soon . Your patience will be greatly appreciated! Thanks! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] : Inconsistent footer between home page and other routes
1 participant