Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social links #225

Merged
merged 6 commits into from
Oct 21, 2023
Merged

Conversation

khushijohri2001
Copy link
Contributor

Fixes Issue

Resolved #224

Changes proposed

  • Added Social Media Links in Footer
  • Added DSA in JS and Docs Link in Footer
  • Added copyright in Footer

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Dark Mode
Screenshot 2023-10-17 at 3 58 30 PM

Light Mode
Screenshot 2023-10-17 at 3 58 47 PM

Mobile View
Screenshot 2023-10-17 at 4 01 40 PM

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:46pm

Copy link
Contributor

@sridharrajaram sridharrajaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Created Social.ts file in config and mapped over it to avoid repetition
@Vishal-raj-1
Copy link
Member

Hey @khushijohri2001 There are two basic merge conflicts in your PR. Please Fix this issue asap, Rest all good

@khushijohri2001
Copy link
Contributor Author

@Vishal-raj-1 @ManishBisht777 resolved the merge conflict. Please check the final output!

@Vishal-raj-1 Vishal-raj-1 merged commit ab25d89 into FrontendFreaks:master Oct 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Adding Social Media Links
4 participants