Button/link consistency #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
Thanks for the contribution @khushijohri2001 Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Resolved #222
Changes proposed
There is no consistency in the styling and naming of buttons. Somewhere the buttons/links are rounded and somewhere it is squared. In the header, the Mentorship button has the link to Discord but it should be Join Community.
Rename Join Community to Join Discord Community, to specify and give a hit of what the community is like.
(Changes in Header, Footer, and other sections)
Check List (Check all the applicable boxes)
Screenshots
Button.style.and.rename.mov
Note to reviewers