fixed active menu option issue #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 10 Frequently asked React Theory Interview Questions under Build Batch > React > Fundamental > Interview Questions (New Tab)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DSA card missing in DOCS-Get Started
…dme-updated readme clone url updated
…ry-interview-questions Feat: Added React Theory Interview Questions
…-button-style Navbar dsa button style
Vishal-raj-1
requested changes
Oct 13, 2023
components/layout/sidebar-nav.tsx
Outdated
| @@ -107,7 +107,7 @@ export function DocsSidebarNavItem({ | |||
| "bg-muted": pathname === item.href, | |||
| })} | |||
| > | |||
| {item.title} | |||
| {item.title}uh | |||
There was a problem hiding this comment.
will remove it soon
components/code-editor.tsx
Outdated
| )} | ||
| </> | ||
| ); | ||
| )} */} |
There was a problem hiding this comment.
why did you comment this section?
There was a problem hiding this comment.
sorry, I was testing something, I am making this file proper as well
…responsive Fix: In small screen Youtube iframe is causing problems to the page
|
I made the changes ✅ |
Vishal-raj-1
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixed #195
Changes proposed
Screenshots
Note to reviewers
I fixed the issue and now whichever page we go to, that nav option will be active respectively.