Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when migrating with existing webhooks.tag_id foreign #65

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix error when migrating with existing webhooks.tag_id foreign #65

merged 2 commits into from
Oct 16, 2023

Conversation

dsevillamartin
Copy link
Member

Fixes #64

Changes proposed in this pull request:

  • Create migration that removes both foreign key & index of tag_id column

Reviewers should focus on:
I think this should work with prefixes... but not entirely sure. Haven't tested that aspect.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@jtojnar
Copy link

jtojnar commented Oct 15, 2023 •
edited
Loading

Can confirm the migration succeeded with 166861e:

Migrating extension: fof-webhooks
Migrated: 2023_06_07_000000_remove_tag_id_constraint
Migrated: 2023_06_07_change_tag_id_to_json

@dsevillamartin dsevillamartin marked this pull request as ready for review October 16, 2023 00:07
@dsevillamartin dsevillamartin merged commit dec767e into master Oct 16, 2023
4 checks passed
@dsevillamartin dsevillamartin deleted the ds/fix-tag-id-constraint-migration branch October 16, 2023 00:10
@dsevillamartin
Copy link
Member Author

dsevillamartin commented Oct 16, 2023 •
edited
Loading

Thanks for verifying @jtojnar ! I've released v1.2.2 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flarum migrate broken in 1.2
3 participants
@dsevillamartin @jtojnar @StyleCIBot