Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt the user to safe changes made after the last autosafe #31

Open
pflstr opened this issue Jun 3, 2020 · 2 comments
Open

Comments

@pflstr
Copy link

pflstr commented Jun 3, 2020

If users close the composer and there are unsaved changes, they are prompted: "Discard changes to draft? In this case, wouldn't it make sense to automatically save the draft once more without asking the user?

If people are used to autosafe, they don't understand why they are sometimes asked to discard changes, and sometimes not, if by chance the last autosafe happened just before they decided to close the composer.

@askvortsov1
Copy link
Contributor

If I have a draft but for some reason delete everything in the content and close the composer, autosave will still keep a feasible version. I'm not sure that this would improve the UI, but I'm also not firm in that opinion

@pflstr
Copy link
Author

pflstr commented Jun 4, 2020

If I have a draft but for some reason delete everything in the content and close the composer, autosave will still keep a feasible version.

Not if you are unlucky and autosave hits you just after deleting the content and just before closing the composer.

It should not be a roulette game, which version of your content is saved or if you have the opportunity to reconsider your last action. If you want to protect users from the consequences of careless deletions, you should offer to always save the last three autosafes, Flarum's version of the time machine so to speak ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants