Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve poll options set via FoF Polls #22

Open
pflstr opened this issue May 27, 2020 · 6 comments
Open

Preserve poll options set via FoF Polls #22

pflstr opened this issue May 27, 2020 · 6 comments

Comments

@pflstr
Copy link

pflstr commented May 27, 2020

Similar to #1:

If a discussion with a poll is saved as a draft the poll part is not saved.

@askvortsov1
Copy link
Contributor

For this to work:

  • An extra attributes column will need to be added to the database
  • Anything not in the defined fields (content/title/relationships) should be placed json-encoded into that extra attributes field
  • Everything in that extra attributes field should be made a regular attribute when drafts are loaded into frontend, and when the scheduled command runs.

@askvortsov1
Copy link
Contributor

Alternatively, title and content could also be moved into attributes, hence providing a unified, uniform system for saving and retreiving data. THis would probably be the most extensible option.

@dsevillamartin
Copy link
Member

Don't do anything for now. I think it technically works, but I need to fix some things locally. Don't worry about it, leave it to me.

@askvortsov1
Copy link
Contributor

It doesn't work, I verified it. Poll is stored as an attribute (poll name, relationship to options, etc), not as a relationship.

@askvortsov1
Copy link
Contributor

Not doing anything now, but this might be worth straightening out before y'all tag the release

@dsevillamartin
Copy link
Member

I meant that some of the code for it is there, but not handled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants