Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax for line-names in grid-template-rows/columns should be updated to use brackets #47

Open
FremyCompany opened this issue Apr 13, 2017 · 2 comments
Assignees
Labels

Comments

@FremyCompany
Copy link
Owner

FremyCompany commented Apr 13, 2017

The csswg accepted a change to use [line-name] instead of (line-name) when giving names to lines between tracks. The polyfill and its examples are still built on the previous iteration which used the parentheses. That should be updated (and it should be straightforward to do so, though fixing the examples is really what will take the most time).

Discovered by @Aloso initially in issue #26

@FremyCompany FremyCompany self-assigned this Apr 13, 2017
@FremyCompany
Copy link
Owner Author

An example of example that is currently broken:
https://rawgit.com/FremyCompany/css-grid-polyfill/master/demo/css-grid/layout4.html

@gajus
Copy link

gajus commented May 19, 2017

Would be nice to see this getting fixed. Furthermore, it is not clear from the README.md which spec this polyfill implements (seeing that you consider this a bug, I am guessing the latest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants