Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default text from Light to Regular (Source Sans Pro) #61

Open
DeniseColbert opened this issue Jul 2, 2019 · 2 comments
Open
Assignees

Comments

@DeniseColbert
Copy link
Collaborator

Please go ahead and make this change @arswright-alt-uk

@ghost ghost self-assigned this Jul 2, 2019
@ghost
Copy link

ghost commented Jul 2, 2019

@DeniseColbert Change is live for Review/QA at https://test2.freeukgenealogy.org.uk/ - a few notes:

Owing to issues with deprecated nodejs packages and a dependency issue ("[email protected] requires a peer of grunt@>=1 but none was installed." but npm show grunt version reports 1.0.4) this change was accomplished by linking the "Source Sans Pro (Light)" font files to "Source Sans Pro (Regular)" (ugly hack but I don't have a working SASS compiler and I had to install a deprecated version of nodejs just to get far enough along to encounter that bug).

The letter-spacing and font-size CSS properties have not changed, however, the Regular typeface will occupy more horizontal space (compare side-by-side with https://test3.freeukgenealogy.org.uk/ or the live site) which has an impact on how many elements appear - will leave it up to you whether you want to proceed with promoting this change.

@DeniseColbert
Copy link
Collaborator Author

To assess if we can implement without additional horizontal space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants