Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all status codes are handled in Sntp_StatusToStr() function #82

Closed
eeFLis opened this issue Jan 4, 2024 · 1 comment
Closed

Not all status codes are handled in Sntp_StatusToStr() function #82

eeFLis opened this issue Jan 4, 2024 · 1 comment

Comments

@eeFLis
Copy link

eeFLis commented Jan 4, 2024

Not all cases of SntpStatus_t status codes are handled in Sntp_StatusToStr.
Therefore Sntp_StatusToStr returns "Invalid status code!" also for valid states such as SntpRejectedResponse,SntpErrorSendTimeout
etc.
aggarg added a commit to aggarg/coreSNTP that referenced this issue Jan 5, 2024
@aggarg
Include all SntpStatus_t values in Sntp_StatusToStr
41e2236 
Withtout this change, the function Sntp_StatusToStr would return
"Invalid status code!" for the following valid status codes:

- SntpRejectedResponse
- SntpErrorSendTimeout
- SntpErrorResponseTimeout
- SntpNoResponseReceived
- SntpErrorContextNotInitialized

This issue was reported here - FreeRTOS#82

Signed-off-by: Gaurav Aggarwal <[email protected]>
@aggarg aggarg mentioned this issue Jan 5, 2024
Merged
2 tasks
@aggarg
Copy link
Member

aggarg commented Jan 5, 2024 •
edited
Loading

Thank you for reporting this. The following PR addressed it - #83.

kar-rahul-aws pushed a commit that referenced this issue Jan 7, 2024
@aggarg
Include all SntpStatus_t values in Sntp_StatusToStr (#83)
c5face5 
* Include all SntpStatus_t values in Sntp_StatusToStr

Withtout this change, the function Sntp_StatusToStr would return
"Invalid status code!" for the following valid status codes:

- SntpRejectedResponse
- SntpErrorSendTimeout
- SntpErrorResponseTimeout
- SntpNoResponseReceived
- SntpErrorContextNotInitialized

This issue was reported here - #82

Signed-off-by: Gaurav Aggarwal <[email protected]>

* Fix memory estimates

Signed-off-by: Gaurav Aggarwal <[email protected]>

* Fix spell check

Signed-off-by: Gaurav Aggarwal <[email protected]>

---------

Signed-off-by: Gaurav Aggarwal <[email protected]>
@aggarg aggarg closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eeFLis @aggarg