Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] ESP32 port implementation for both Ethernet and Wi-Fi #1168

Open
ryan4xen opened this issue Jul 8, 2024 · 2 comments
Open
Labels
help wanted Extra attention is needed

Comments

@ryan4xen
Copy link

ryan4xen commented Jul 8, 2024

I am currently porting the TCP stack to work with the esp-idf as an alternative to the existing lwIP. Though during the implementation I found that only Wi-Fi was actually implemented, but using _Eth_ naming. At this stage I am only personally doing a Wi-Fi implementation, though would be good to clean this up.

For example:

static BaseType_t xESP32_Eth_NetworkInterfaceInitialise( NetworkInterface_t * pxInterface )
{
    static BaseType_t xMACAdrInitialized = pdFALSE;
    uint8_t ucMACAddress[ ipMAC_ADDRESS_LENGTH_BYTES ];

    if( xInterfaceState == INTERFACE_UP )
    {
        if( xMACAdrInitialized == pdFALSE )
        {
            esp_wifi_get_mac( ESP_IF_WIFI_STA, ucMACAddress );
            FreeRTOS_UpdateMACAddress( ucMACAddress );
            xMACAdrInitialized = pdTRUE;
        }

        return pdTRUE;
    }

    return pdFALSE;
}

Unless I am missing something I believe someone originally intended to implement the Ethernet driver, but ended up with a Wi-Fi one instead.

@htibosch
Copy link
Contributor

htibosch commented Jul 8, 2024

The +TCP driver for ESP32 in portable/NetworkInterface/esp32, is indeed only for WiFi.

These seem to be the official driver sources on github.com/espressif.

If you decide to create a ESP32 Ethernet driver for +TCP, you can either:

It shouldn't be too difficult, assuming that the espressif driver is well tested.

@moninom1
Copy link
Member

HI @ryan4xen
Are you planning on creating a pull request as suggested by hein?

@amazonKamath amazonKamath added the help wanted Extra attention is needed label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants