Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect upper limit of 8k in config file #120

Open
DimitriPapadopoulos opened this issue May 8, 2024 · 1 comment · May be fixed by #122
Open

Incorrect upper limit of 8k in config file #120

DimitriPapadopoulos opened this issue May 8, 2024 · 1 comment · May be fixed by #122

Comments

@DimitriPapadopoulos
Copy link
Contributor

Not sure where the upper limit of 8k comes from:

# The shared secret use to "encrypt" and "sign" packets between
# the NAS and FreeRADIUS. You MUST change this secret from the
# default, otherwise it's not a secret any more!
#
# The secret can be any string, up to 8k characters in length.

As far as I can see, the current maximal length of the shared secret is 256:

#define MAX_SECRET_LENGTH (16 * 16) /* MUST be multiple of 16 */

@alandekok
Copy link
Member

Yes, that needs fixing. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants