Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: raise #1741

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Python: raise #1741

wants to merge 11 commits into from

Conversation

maximiliankaul
Copy link
Contributor

@maximiliankaul maximiliankaul commented Sep 27, 2024

Fixes #1710

Copy link
Contributor

@KuechA KuechA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the intended order of the PRs. I made several comments on the parts in cpg-core in the PR #1733 which also apply here of course. The python-part looks straightforward but needs a test.

@maximiliankaul
Copy link
Contributor Author

Not sure what's the intended order of the PRs. I made several comments on the parts in cpg-core in the PR #1733 which also apply here of course. The python-part looks straightforward but needs a test.

I want to have smaller, easier to review PRs:

  1. We implement the general concepts in Implement a throw or raise statement #1733
  2. We use them in all other languages. This PR being one of the required changes, after 1. is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Raise in python
2 participants