feat: add comparison of functions by content #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
commented
Oct 18, 2022
| @@ -18,8 +18,7 @@ function equal(a, b) { | |||
| if (Array.isArray(a)) { | |||
| length = a.length; | |||
| if (length != b.length) return false; | |||
| for (i = length; i-- !== 0;) | |||
| if (!equal(a[i], b[i])) return false; | |||
| for (i = length; i-- !== 0; ) if (!equal(a[i], b[i])) return false; | |||
There was a problem hiding this comment.
Sorry, it looks like my IDE prettier settings did a bit of reformatting here. If there's a particular code style that's meant to be followed, would be good to get a prettier config into the repo
There was a problem hiding this comment.
As the source code comments indicate, we track upstream source code from https://github.com/epoberezkin/fast-deep-equal and then place our updates inside. Community PRs usually just attempt to update our specific modifications here or update the upstream library first.
scottrippey
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #114
It's a very common pattern to declare functions inline now-a-days, which causes problems when used with
react-fast-comparebecause the library currently only compares functions referentially.Checklist:
test-ts-defsandtest-ts-usage