Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple #88

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Add simple #88

merged 6 commits into from
Apr 19, 2024

Conversation

cpresler
Copy link
Contributor

Description

Added an optional simple prop to the badges (features and standard project) to allow for hiding the description and displaying a larger abbreviation, or logo only - better for badge legibility at small sizes. Once this is merged I will incorporate it into the OSS Tracker to fix the illegible descriptions in the badges.
Current small badge in OSS tracker
Screenshot 2024-04-19 at 1 26 52 PM

Current badge at small size:
Screenshot 2024-04-19 at 1 30 58 PM

Proposed update with simple prop at small size:
Screenshot 2024-04-19 at 1 31 08 PM

Fixes # (issue)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update - documentation has been updated

How Has This Been Tested?

Tested locally using the storybook instance in the project.

Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: 11c416d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

src/ProjectBadge.tsx Outdated Show resolved Hide resolved
src/ProjectBadge.tsx Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@carbonrobot carbonrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@cpresler cpresler merged commit f712c1a into master Apr 19, 2024
1 check passed
@cpresler cpresler deleted the add-simple branch April 19, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants