Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0][ForEvolve.ExceptionMapper.Serialization.Json] Does not work without AddMvcCore() #5

Closed
Carl-Hugo opened this issue Nov 21, 2021 · 1 comment

Comments

@Carl-Hugo
Copy link
Member

Carl-Hugo commented Nov 21, 2021

Actual result

The DI container is not able to create ProblemDetailsFactory without registering AddMvcCore().

Expected result

There is no need to register AddMvcCore() to make serialization work. Either register the required dependencies or create a custom ProblemDetailsFactory implementation.

More info

@Carl-Hugo
Copy link
Member Author

The following PR circumvents this: #7

If the following issue gets approved/fixed, it will be possible to remove the copy of DefaultProblemDetailsFactory from the ExceptionMapper source code, see: dotnet/aspnetcore#49982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant