Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language translation issue #53

Open
grayson-harrington opened this issue Feb 16, 2021 · 5 comments
Open

language translation issue #53

grayson-harrington opened this issue Feb 16, 2021 · 5 comments
Labels
discussion Open to discussion enhancement New feature or request

Comments

@grayson-harrington
Copy link
Contributor

The past tense sentence that can be shown when a player wins is either "you won!" Or "AI won!"

The Spanish translation of these sentences is "tú ganaste" and "AI ganó" respectively.

The conjugation changes depending on who won the game. Right now the localizations are set up so that each word in the original phrase is translated separately so "you" "AI" and "won" are all translated separately. Basically to fix the problem we should translate the whole phrases rather than the smaller parts of the phrases.

@slovnicki
Copy link
Collaborator

And this will also be needed for Croatian, hadn't realized until you said it.

I will generalize the title.

@slovnicki slovnicki changed the title Spanish language translation issue language translation issue Feb 16, 2021
@slovnicki
Copy link
Collaborator

@Goober0329 can the word "wins" work for all genders?

I'm thinking of the future situation where players will be choosing their names, therefore implicitly choosing genders.

@grayson-harrington
Copy link
Contributor Author

It can work for all genders in Spanish, but I'm not sure about other languages.

@YazeedAlKhalaf
Copy link
Contributor

YazeedAlKhalaf commented Feb 16, 2021

If you mean masculine and feminine there is a solution from easy_localization
https://pub.dev/packages/easy_localization

To create it, instead of gender in the key write the word name and then fill in the three values: male, female, and other with correct forms.

image

@RomanJos
Copy link

In french too I have issue with this, the congugation of "win" has to do with male/female, singular/plural and the time like past present etc.
The best solution for me would be to create a language key for every string instead of word as it is the case for win, wins and won

@slovnicki slovnicki added discussion Open to discussion enhancement New feature or request labels Feb 20, 2021
@slovnicki slovnicki added this to the v1.3.0 milestone Feb 20, 2021
@slovnicki slovnicki removed this from the v1.3.0 milestone Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open to discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants