Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astraltopia cannot search for "Number" Spell/trap cards. #2294

Open
VforViolin opened this issue Dec 23, 2023 · 5 comments
Open

Astraltopia cannot search for "Number" Spell/trap cards. #2294

VforViolin opened this issue Dec 23, 2023 · 5 comments

Comments

@VforViolin
Copy link
Contributor

https://github.com/Fluorohydride/ygopro-scripts/blob/ba09943503c85b11a3d715346241c3110eb78989/c69852487.lua#L50C1-L50C1

Astraltopia, when referencing the "Number" archetype for it's search effect on line 50, uses the code "0x16a", which doesn't appear to be associated with any "Number" cards. Instead, it should use "0x48" as this is the code for "Number" cards.

I'm not a coder, but this appears to be the only problem I've found for this 2 year old bug.

@salix5
Copy link
Collaborator

salix5 commented Dec 23, 2023

0x48 No.(ナンバーズ)
0x16a ナンバーズ
These are 2 different archetypes in Japanese.
So the script is correct.

@VforViolin
Copy link
Contributor Author

VforViolin commented Dec 23, 2023

But the 0x16a isnt used for any other card, while 0x48 is used for every Number card so far, so Im not sure what Astraltopia is supposed to be searching using that code.

@salix5
Copy link
Collaborator

salix5 commented Dec 24, 2023

Yes it is supposed to be.

https://yugipedia.com/wiki/Help:Ruby_characters
There are ruby characters in Japanese.
They show the pronunciation just like Phonetic Alphabet, but they are a part of the language.

For Yugioh cards, the archetype is determined by both kanji and ruby characters.

0x48
No.(ナンバーズ)
Base: No.
Kana: ナンバーズ

0x16a
ナンバーズ
No base

They are 2 different archetype.
The English version translate into the same word Number probably for simplicity.

@VforViolin
Copy link
Contributor Author

Astraltopia is supposed to be able to search "Number" spells and traps. Currently, it cannot search "Number" spells or traps. The list of "Number" cards Astraltopia is supposed to be able to search are as follows:

Spells
Numbers Last Hope (4606229)
Numbers Eveil (20994205)
Glorious Numbers (60944809)

Traps
Numbers Overlay Boost (97738431)
Number Wall (847915)
Numbers Protection (68630939)

Currently, Astraltopia cannot search any of these "Number" cards, because 0x16a isnt used for any of these cards.

@salix5
Copy link
Collaborator

salix5 commented Dec 24, 2023

Currently, Astraltopia cannot search any of these "Number" cards, because 0x16a isnt used for any of these cards.

Yes it can.
If it cannot do so on your machine, check if your cdb file is wrong.

ナンバーズ・エヴァイユ
Numbers Eveil

It does not have No. in the Japanese version, so I am absolutely sure it is 0x16a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants