Fix "home" link on Left Nav #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flowforge-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ZJvandeWeg chasing for this please. Nick just raised it with me independently that it was broken, and I knew I'd fixed it somewhere |
|
This change would break the core node Nav though? |
It doesn't, test it out: https://deploy-preview-942--flowforge-website.netlify.app/node-red/core-nodes/ |
knolleary
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regression introduced in #911 meant that the "docs" and "handbook" links at the top of the left navigation were just going to our homepage.
Problem was a missing
elsein the ternary operator.Can confirm that this link now works across all of handbook, docs and core-nodes documentation.
Checklist