Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing / to /docs and /handbook links in nav #941

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

joepavitt
Copy link
Contributor

Description

When developing locally, clicking "docs" or "handbook" in the top nav bar takes us to /docs and /handbook respectively. The problem here is that a lot of the local linking on the homepages within these resources use ./page notation, which, given the lack of trailing slash at the current URL, means we end up with a 404. This doesn't occur in production because Netlify auto-redirects traffic from /any-path-here to /any-path-here/

Checklist

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for flowforge-website ready!

Name Link
🔨 Latest commit 4498fc9
🔍 Latest deploy log https://app.netlify.com/sites/flowforge-website/deploys/64a82310940f79000812a593
😎 Deploy Preview https://deploy-preview-941--flowforge-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joepavitt joepavitt requested a review from ZJvandeWeg July 7, 2023 14:37
@ZJvandeWeg ZJvandeWeg merged commit 62eb0e3 into main Jul 7, 2023
5 checks passed
@ZJvandeWeg ZJvandeWeg deleted the local-docs-links branch July 7, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants