Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog : Using FlowFuse Project Nodes for Faster and More Efficient Com… #2631

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

sumitshinde-84
Copy link
Collaborator

…munication

Description

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 26.9%, saving 2.35 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/09/images/project-nodes.png 8.74 KB 6.39 KB -26.9% View diff

1403 images did not require optimisation.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good clean well written article.

If I had to say one thing it would be not calling out when/why to use broadcast vs direct. That could be a follow up article (a part 2, deeper dive) that refers back to this article as reference.

I will approve, you can decide to update or follow up.

@Steve-Mcl
Copy link
Contributor

PS, @sumitshinde-84 If something is ready for review, please mark it as read for review.

@Steve-Mcl
Copy link
Contributor

Sorry, forgot to add, the date probably needs updating (it is currently marked as Sept 13th)

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 26.9%, saving 2.35 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/10/images/project-nodes.png 8.74 KB 6.39 KB -26.9% View diff

1412 images did not require optimisation.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have an image added to the 09/images directory

@sumitshinde-84
Copy link
Collaborator Author

You seem to have an image added to the 09/images directory

Removed Now !

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good.

Will probably need the date updating one last time before publish.

@ZJvandeWeg ZJvandeWeg merged commit 270bd97 into main Oct 8, 2024
6 checks passed
@ZJvandeWeg ZJvandeWeg deleted the flowfuse-project-nodes branch October 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants