Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Node-RED container to 4.0.4 #477

Merged
merged 2 commits into from
Oct 10, 2024
+2 −2
Merged

chore: Bump Node-RED container to 4.0.4 #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56e696
Update Dockerfile-4.0
knolleary Oct 9, 2024
e8c3ae9
Update Dockerfile-3.1
hardillb Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node-red-container/Dockerfile-3.1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM nodered/node-red:3.1.12-18
FROM nodered/node-red:3.1.13-18

ARG REGISTRY
ARG REGISTRY_TOKEN

Check warning on line 4 in node-red-container/Dockerfile-3.1

View workflow job for this annotation

GitHub Actions / Build 3.1.x container images / build

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "REGISTRY_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ARG BUILD_TAG=latest
RUN if [[ ! -z "$REGISTRY_TOKEN" ]]; then echo "//$REGISTRY/:_authToken=$REGISTRY_TOKEN" >> ~/.npmrc ; fi
RUN if [[ ! -z "$REGISTRY" ]] ; then npm config set @flowfuse:registry "https://$REGISTRY"; fi
Expand Down
2 changes: 1 addition & 1 deletion node-red-container/Dockerfile-4.0
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM nodered/node-red:4.0.3-20
FROM nodered/node-red:4.0.4-20

ARG REGISTRY
ARG REGISTRY_TOKEN

Check warning on line 4 in node-red-container/Dockerfile-4.0

View workflow job for this annotation

GitHub Actions / Build 4.0.x container images / build

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "REGISTRY_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ARG BUILD_TAG=latest
RUN if [[ ! -z "$REGISTRY_TOKEN" ]]; then echo "//$REGISTRY/:_authToken=$REGISTRY_TOKEN" >> ~/.npmrc ; fi
RUN if [[ ! -z "$REGISTRY" ]] ; then npm config set @flowfuse:registry "https://$REGISTRY"; fi
Expand Down
Loading