Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure default private ca cert cm name #451

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Aug 14, 2024

fixes #450

Description

The deployment template was missing the default value for the private ca cert configmap

As was the flowforge.yml configmap.

Related Issue(s)

#450

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Aug 14, 2024
@hardillb hardillb changed the title Fix: Ensure default private ca cert cm name fix: Ensure default private ca cert cm name Aug 14, 2024
@ppawlowski
Copy link
Contributor

I am confused with names, since:

@hardillb
Copy link
Contributor Author

@ppawlowski the double t was a typo

@ppawlowski ppawlowski merged commit bae11f1 into main Aug 15, 2024
6 checks passed
@ppawlowski ppawlowski deleted the fix-private-ca-cert branch August 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrivateCA configMapName default name not working
2 participants